Invisible color not working in simulator

epicdude312 · November 5, 2017, 1:39am

I was just porting Blocky World to the latest version of the simulator and I noticed a little issue. Apparently the code for the invisible color had disappeared in the Display::directPixel() function. It might be a good idea to add that back

jonne · November 5, 2017, 5:22am

Good catch! Will be replaced

epicdude312 · November 28, 2017, 9:50pm

It’s missing again! I’m not that experienced with Github, so I don’t know how to make a PR, but you might want to fix it ASAP. I had purple lines all over my game at first

I also had a strange issue where the invisible color was looping around, so an invisible color of 16 did not draw pixels with color 0. I have no idea what’s going on, but a quick addition of && invisiblecolor < 16 did the trick for now.

Pharap · November 28, 2017, 10:20pm

If you tell me what file and line number (if you know them) I can have a quick look and make a PR or something.

epicdude312 · November 28, 2017, 10:22pm

Pokitto\POKITTO_CORE\PokittoDisplay.cpp

Line 211

Pharap · November 28, 2017, 11:47pm

Sorry for the delay, was fixing code on another project.

Line 211 according to github is Display::directPixel:

github.com

pokitto/PokittoLib/blob/master/Pokitto/POKITTO_CORE/PokittoDisplay.cpp#L211


m_w = POK_LCD_W;
m_h = POK_LCD_H;
setFont(DEFAULT_FONT);
invisiblecolor=17;
bgcolor=0;
if (POK_COLORDEPTH) m_colordepth = POK_COLORDEPTH;
else m_colordepth = 4;
#if POK_GAMEBUINO_SUPPORT
setColorDepth(1);
#endif // POK_GAMEBUINO_SUPPORT


// Reset sprites
m_tilecolorbuf = NULL; //!!HV
for (uint8_t s = 0; s < SPRITE_COUNT; s++) m_sprites[s].bitmapData = NULL;
}


uint16_t Display::getWidth() {
return width;
}


uint8_t Display::getNumberOfColors() {

That doesn’t seem right?

If you look on the page and find the bit of code you’re talking about, click the line number and it’ll take your browser to the line number.
You can then either copy the url in your address bar or click on the ... and there will be a Copy permalink option which should copy the address into your clipboard.

Paste that here with the proposed change and I’ll turn it into a fork or a branch and make a PR for review.
(If none of that makes any sense, it basically means I’ll get the code change ready and let the others read it to make sure it’s right before it gets accepted.)

epicdude312 · November 29, 2017, 2:50am

github.com

pokitto/PokittoLib/blob/963460e2652b6bccffeda0a51886f4d35019626e/Pokitto/POKITTO_CORE/PokittoDisplay.cpp#L211




void Display::clearLCD() {
lcdFillSurface(0);
setCursor(0,0); // old basic computer style
}


void Display::fillLCD(uint16_t c) {
lcdFillSurface(c);
}


void Display::directPixel(int16_t x, int16_t y, uint16_t color) {
lcdPixel(x,y,color);
}


void Display::directRectangle(int16_t x, int16_t y,int16_t x2, int16_t y2, uint16_t color) {
lcdRectangle(x,y,x2,y2,color);
}


void Display::begin() {
lcdInit();
}

In between lines 211 and 212, add

if ((invisiblecolor<PALETTE_SIZE && invisiblecolor < 16 && color==palette[invisiblecolor])) return; //do not draw transparent pixels

I don’t know what’s going on with the PALETTE_SIZE, because when I put that without invisiblecolor < 16, the invisible color was wrapping around to color 0. Someone might want to look into that, but this is at least a temporary fix that’ll work for 16-color palettes. I guess you could in theory add another argument to the function?

Pharap · November 29, 2017, 2:35pm

For the record I’m not entirely sure this is the right solution, but I don’t know enough about the display modes to judge either way.

I’ve made a PR out of it regardless and hopefully someone will come along and say ‘no this is wrong’ or ‘yes this is right’.

Hanski · November 29, 2017, 7:42pm

You could put a breakpoint in code and see why it fails in that line.

Pharap · November 30, 2017, 11:30pm

The PR has been merged.