drawPixelRaw in Mode1 (220x176x2bits) drawing outside screenbuffer

jonne · July 21, 2018, 11:57pm

Latest version of display routines (drawPixelRaw) seems to draw outside the screenbuffer in some instances (@FManga)

I tracked down this pretty odd bug using a hardware debugger when I saw odd behaviour in the Tracker software (see below)

By adding a memory write breakpoint, I found it was drawPixelRaw writing to memory outside the actual screenbuffer.

I am not pressing any buttons in the video below. That is the drawPixelRaw writing on top of the memory of instrument[15].wave

FManga · July 22, 2018, 12:47am

Can you send me a bin? How do I reproduce this bug?
Does this have the bug?
firmware.bin (91.2 KB)
If not, I’ll send a PR.

FManga · July 22, 2018, 6:08pm

bump

jonne · July 22, 2018, 6:26pm

Yeeeeeesssss… later today

Pharap · September 5, 2018, 12:40pm

I’m bumping this because I noticed it on the todo list.
Is this still a problem?

FManga · September 5, 2018, 1:17pm

I’d guess it is. IIRC I found what could be the cause of the bug in bufferChar (not drawPixelRaw), but since I was never able to replicate the issue, I couldn’t be sure.